Adding an option to select the specific Python version. #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CMake already detects the Python version. Since DFTB4 is installed via pip install dftb4, I don’t see why we need to add a new CMake option to force a specific Python version. |
Contributor
Author
|
dftd4 does not work with recent python. Current cmake only detects the most recent version. When you have multiple versions of python, it is not possible to specify a particular one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new CMake option -DOQP_PYTHON_VERSION= has been introduced, allowing users to specify the desired Python version for the build process.
With this, I think we can allow pip install dftd4 as default.
Usage:
To build with Python 3.11, include the following flag in your CMake command:
-DOQP_PYTHON_VERSION=3.11